Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix host release name nil pointer #2250

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix host release name nil pointer #2250

merged 3 commits into from
Oct 21, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Oct 21, 2024

fixing #2245

@steiler steiler linked an issue Oct 21, 2024 that may be closed by this pull request
@steiler steiler requested a review from hellt October 21, 2024 13:03
utils/file.go Show resolved Hide resolved
Copy link
Member

@hellt hellt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, thanks @steiler
have only one comment about caching

@hellt hellt merged commit 5beff79 into main Oct 21, 2024
64 of 65 checks passed
@hellt hellt deleted the HostReleaseName branch October 21, 2024 20:50
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.79%. Comparing base (6859e39) to head (2966ad2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
utils/file.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   52.12%   51.79%   -0.33%     
==========================================
  Files         172      172              
  Lines       12714    16653    +3939     
==========================================
+ Hits         6627     8626    +1999     
- Misses       5174     7111    +1937     
- Partials      913      916       +3     
Files with missing lines Coverage Δ
nodes/host/host.go 91.89% <100.00%> (+57.04%) ⬆️
utils/file.go 57.99% <75.00%> (-0.70%) ⬇️

... and 161 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host node panics if the distro doesn't have a lsb-release file
2 participants