Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IOL MAC generation #2262

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

kaelemc
Copy link
Contributor

@kaelemc kaelemc commented Oct 26, 2024

IOL generates it's own hardware MAC addresses for its interfaces. It turns out we can use these instead of generating our own MAC addresses.

This PR removes:

  • The MAC address generation in containerlab.
  • references in the template config to any generated MACs.
  • Any other variables/structs vars which store the generated MAC addresses.

@kaelemc
Copy link
Contributor Author

kaelemc commented Oct 26, 2024

Tested this and it works, we can wait for @DanPartelly to test as well.

@DanPartelly
Copy link
Contributor

Tested it as well. Working as intended.

@hellt hellt merged commit 17b295e into srl-labs:main Oct 27, 2024
64 of 65 checks passed
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.16%. Comparing base (9e96472) to head (aae93ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2262      +/-   ##
==========================================
- Coverage   51.18%   51.16%   -0.03%     
==========================================
  Files         172      172              
  Lines       16689    16682       -7     
==========================================
- Hits         8542     8535       -7     
  Misses       7235     7235              
  Partials      912      912              
Files with missing lines Coverage Δ
nodes/iol/iol.go 82.01% <ø> (-0.65%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants