json schema refactor. #2384
Open
json schema refactor. #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2025 17:22
…a fields and so we can have strict validation. 2/ Removed "minItems" from scalar properties (e.g., for string or number). Because thing could go haywire as keyword "minItems" should be used for array, while the keyword "minItems used in type string and number. 3/ Unified enum values for "image-pull-policy" and "restart-policy" to avoid duplicates and different case variants. 4/ Factored out complex regex patterns for ports and publish into separate definitions (port-pattern and publish-pattern). 5/ Switched kinds from many hardcoded properties to a single patternProperties rule for flexibility in topology.kinds. 6 / AllOf logic remains intact for kind-conditional type constraints, but ensured they don’t contradict each other.
hellt
reviewed
Jan 8, 2025
| @@ -0,0 +1,924 @@ | |||
| { | |||
| "$id": "https://containerlab.dev/clab.schema.json", | |||
There was a problem hiding this comment.
@asadarafat what is this file for?
There was a problem hiding this comment.
@hellt, I assume you are referring to schemas/clab.schema.jsonc. It is essentially the same as clab.schema.json, but with added comments. The .jsonc format is supported by VSCode, allowing for better readability and enhanced documentation within the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionalProperties: false is used in more place to forbid extra fields and so we can have strict validation.minItemsfrom scalar properties (e.g., for string or number). Because thing could go haywire as keywordminItemsshould be used for array, while the keywordminItemsused in type string and number in previous schemamage-pull-policyandrestart-policyto avoid duplicates and different case variants.