Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added centralized magic var replacer and support replacer for execs #2395

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 15, 2025

fix #2393

it is immediately clear if doing a global replacement is possible due to the requirement to support nodeName variable that needs to have node name parsed first.

Instead, the node vars are being applied to the most wanted sections:

  • binds
  • execs
  • startup-config

@hellt hellt merged commit a75e770 into main Jan 15, 2025
65 checks passed
@hellt hellt deleted the clabnodename-more-places branch January 15, 2025 14:12
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.92%. Comparing base (5132320) to head (99add4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
clab/config.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   51.90%   51.92%   +0.02%     
==========================================
  Files         172      172              
  Lines       17300    17316      +16     
==========================================
+ Hits         8979     8992      +13     
- Misses       7379     7381       +2     
- Partials      942      943       +1     
Files with missing lines Coverage Δ
clab/config.go 68.16% <85.00%> (+0.46%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__clabNodeName__ magic var should be expanded globally, not only for startup-config
1 participant