Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle v6 rules for the mgmt bridge with nftables/iptables #2397

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 15, 2025

  • add v6 nftables
  • remove v6 nftables
  • add v6 iptables
  • remove v6 iptables

@hellt hellt changed the title Added v6 rule for mgmt bridge with nftables Handle v6 rules for the mgmt bridge with nftables/iptables Jan 16, 2025
@hellt hellt marked this pull request as ready for review January 16, 2025 13:58
@hellt hellt merged commit 6257f4f into main Jan 16, 2025
61 checks passed
@hellt hellt deleted the docker-rules-for-brs branch January 16, 2025 14:03
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (a75e770) to head (f880e38).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
runtime/docker/firewall/iptables/client.go 0.00% 54 Missing ⚠️
runtime/docker/firewall/nftables/client.go 57.69% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
- Coverage   51.89%   51.85%   -0.05%     
==========================================
  Files         172      172              
  Lines       17316    17380      +64     
==========================================
+ Hits         8986     9012      +26     
- Misses       7386     7419      +33     
- Partials      944      949       +5     
Files with missing lines Coverage Δ
runtime/docker/firewall.go 33.33% <ø> (ø)
runtime/docker/firewall/nftables/client.go 68.64% <57.69%> (-2.52%) ⬇️
runtime/docker/firewall/iptables/client.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant