Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup v4 and v6 allowing rules when using bridges #2401

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 16, 2025

fix #2389

v4 rules were set up already, we were missing the v6 counterpart

@hellt hellt marked this pull request as ready for review January 16, 2025 20:28
@hellt hellt merged commit 3f31afd into main Jan 17, 2025
67 checks passed
@hellt hellt deleted the fw-rules-for-bridges branch January 17, 2025 07:50
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 40 lines in your changes missing coverage. Please review.

Project coverage is 51.97%. Comparing base (6257f4f) to head (4786047).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
runtime/docker/firewall/iptables/client.go 0.00% 32 Missing ⚠️
nodes/bridge/bridge.go 75.00% 2 Missing and 1 partial ⚠️
runtime/docker/firewall/nftables/client.go 92.50% 1 Missing and 2 partials ⚠️
runtime/docker/firewall.go 88.88% 1 Missing ⚠️
runtime/docker/firewall/firewall.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2401      +/-   ##
==========================================
+ Coverage   51.85%   51.97%   +0.11%     
==========================================
  Files         172      172              
  Lines       17380    17394      +14     
==========================================
+ Hits         9012     9040      +28     
+ Misses       7419     7412       -7     
+ Partials      949      942       -7     
Files with missing lines Coverage Δ
runtime/docker/docker.go 69.42% <100.00%> (+0.75%) ⬆️
runtime/docker/firewall/nftables/rule.go 83.05% <100.00%> (+1.56%) ⬆️
runtime/docker/firewall.go 37.03% <88.88%> (+3.70%) ⬆️
runtime/docker/firewall/firewall.go 58.33% <66.66%> (ø)
nodes/bridge/bridge.go 65.71% <75.00%> (+3.36%) ⬆️
runtime/docker/firewall/nftables/client.go 76.41% <92.50%> (+7.76%) ⬆️
runtime/docker/firewall/iptables/client.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerlab fails to manage nft ipv6 forwarding policy
1 participant