Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ip addr retrieval for inspect --all case #434

Closed
wants to merge 1 commit into from
Closed

Conversation

hellt
Copy link
Member

@hellt hellt commented May 28, 2021

Hi @karimra
I wonder if you consider this to be a less intrusive approach as opposed to #433 ?
The assumption here is that clab containers can have only one network they are connected to

@karimra
Copy link
Member

karimra commented May 28, 2021

That was the way it was done before the runtime introduction.

I did it that way first then decided to query the bridges that were created by clab, users can always do a docker network connect someDockerNetwork clab-nodeX making the output random.

But under the assumption that only one docker network is connected, both ways work. The extra step is a docker network listing.

@hellt
Copy link
Member Author

hellt commented May 28, 2021

agree, that makes sense to let ppl to mess with container networking afterwards

@hellt hellt closed this May 28, 2021
@hellt hellt deleted the fix-ins-a-v2 branch October 22, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants