New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework runtime interface #448

Merged

hellt merged 1 commit into master from runtime-update

Jun 15, 2021

Member

karimra commented Jun 15, 2021

This PR decouples runtime import from its implementations.
This should help avoiding import cycles when implementing node kind interface.


          rework runtime interface

b9b4f07

Member

hellt commented Jun 15, 2021

thanks @karimra
as far as I understand, the important piece is that here we do not anymore import the docker package?
https://github.com/srl-labs/containerlab/pull/448/files#diff-bb8ad382f59edfae9297e446895a161036f39115189e67da9d9f377a684a8f82L12

Member Author

karimra commented Jun 15, 2021

yes, that's the idea.

hellt merged commit 6c4d97e into master

hellt deleted the runtime-update branch

October 22, 2021 17:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet