Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ceos support for extras #819

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Conversation

sulrich
Copy link
Contributor

@sulrich sulrich commented Mar 12, 2022

overview

ceos allows some parameters to be overridden or additional options to be set by placing files within the flash directory. this PR adds support for a ceos-specific "extra" to copy user provided files into the flash directory on startup.

additionally, this PR sets the EBTA environment value to be "1" which is the preferred setting.

sulrich added 3 commits March 11, 2022 17:21
adds a 'ceos-overrides' extras option to be used with ceos.  this will
allow for the specification of a ceos-config, toggles_overide, etc. to
be copied to the flash directory to be used by the container on start.
@hellt
Copy link
Member

hellt commented Mar 12, 2022

Hi @sulrich
since this operation seems to be a generic one, could it be named copy-to-flash instead of overrides?

PS. Also what is the benefit do you see when copying the files, instead of using binds?

@sulrich
Copy link
Contributor Author

sulrich commented Mar 12, 2022

@hellt happy to change this to 'copy-to-flash' or something similarly generic.

wrt this vs. binds, it's really kind of a workflow and packaging thing. i tend to use this to inject the extras and then remove the "extras" from the topology file so that i can package this up for storage and restoration without having to worry about binds lurking around.

upon further reflection, it might make more sense to make this into something that's only used on initial setup.

@hellt
Copy link
Member

hellt commented Mar 16, 2022

Hi @sulrich check my changes in the latest commit

I have changed the node name to be ceos-copy-to-flash to avoid ambiguity and also added a step to resolve relative paths relative to the topology file and not the CWD. This is the common logic for paths in clab.

When you confirm that it works as you expected I will merge it

@sulrich
Copy link
Contributor Author

sulrich commented Mar 16, 2022

builds clean, works correctly.

i'm good. thanks!

@hellt hellt merged commit 3b5e0f3 into srl-labs:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants