Merge pull request #27 from alexmasi/ga

Support 'ga' tag as an engineering build
srl-labs · Nov 19, 2022 · df52b70 · df52b70
2 parents 486959c + f53de9d
commit df52b70
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/api/types/v1alpha1/srl_version.go b/api/types/v1alpha1/srl_version.go
@@ -23,10 +23,12 @@ type SrlVersion struct {
 }
 
 func parseVersionString(s string) (*SrlVersion, error) {
-	// for latest or missing tag we consider the version to be an engineering build
-	// with major = 0
-	if strings.ToLower(s) == "latest" || s == "" {
-		return &SrlVersion{"0", "", "", "", ""}, nil
+	// Check if the version string is an engineering build with major = 0
+	engineeringVersions := []string{"", "latest", "ga"}
+	for _, ver := range engineeringVersions {
+		if ver == strings.ToLower(s) {
+			return &SrlVersion{"0", "", "", "", ""}, nil
+		}
 	}
 
 	// https://regex101.com/r/eWS6Ms/3

diff --git a/api/types/v1alpha1/srl_version_test.go b/api/types/v1alpha1/srl_version_test.go
@@ -73,6 +73,11 @@ func TestParseVersionString(t *testing.T) {
 			got:  "latest",
 			want: &SrlVersion{"0", "", "", "", ""},
 		},
+		{
+			desc: "ga",
+			got:  "ga",
+			want: &SrlVersion{"0", "", "", "", ""},
+		},
 		{
 			desc: "empty",
 			got:  "",