Clientset unit tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage ? 19.61%
=======================================
Files ? 10
Lines ? 775
Branches ? 0
=======================================
Hits ? 152
Misses ? 619
Partials ? 4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hellt
commented
Aug 3, 2022
api/clientset/v1alpha1/srlinux.go
Outdated
Comment on lines
105
to
108
| func (s *srlinuxClient) List( | ||
| ctx context.Context, | ||
| opts *metav1.ListOptions, | ||
| opts metav1.ListOptions, | ||
| ) (*typesv1alpha1.SrlinuxList, error) { |
There was a problem hiding this comment.
@marcushines can you share your expert opinion on that func signature and the need for ListOptions to be copied?
The reason I used a pointer here is based on a purely noob approach - a code analyzer told me that the struct is "sizeable", so why not using a pointer?
There was a problem hiding this comment.
I see, this is a common interface pattern used in k8s, probably for a good reason
https://pkg.go.dev/k8s.io/client-go@v0.24.3/kubernetes/typed/core/v1#PodInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #15