Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added startup-config provisioning via a temp dir #22

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Oct 4, 2022

previously used method of mounting the startup-config configmap to /etc/opt/srlinux/config.json prevented users from using command on saving the running config to startup with commit save and tools system configuration save, as the rename operation is now allowed on read only file systems.

To workaround that, the current PR uses a temp location /tmp/startup-config for the original configmap, and then copies files contained within this configmap to the target dir at kne-entrypoint.sh stage.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #22 (08fcfa6) into main (938f6b9) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   19.61%   19.71%   +0.10%     
==========================================
  Files          10       10              
  Lines         775      771       -4     
==========================================
  Hits          152      152              
+ Misses        619      615       -4     
  Partials        4        4              
Impacted Files Coverage Δ
controllers/pod.go 0.00% <0.00%> (ø)
controllers/srlinux_controller.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hellt hellt merged commit 88b58e7 into main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant