Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relaxed regexp to parse version out of a tag #24

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Oct 14, 2022

to allow parsing custom image tags such as:

version_22.6.4-30192

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #24 (beaf7b0) into main (88b58e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   19.71%   19.71%           
=======================================
  Files          10       10           
  Lines         771      771           
=======================================
  Hits          152      152           
  Misses        615      615           
  Partials        4        4           
Impacted Files Coverage Δ
api/types/v1alpha1/srl_version.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hellt hellt merged commit 486959c into main Oct 14, 2022
desc: "version_0.0.0-34652",
got: "version_0.0.0-34652",
want: &SrlVersion{"0", "0", "0", "34652", ""},
},
{
desc: "latest",
got: "latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see the following usecases be met:

  1. If a user specifies a model that does not require a license then the tag of their image should not matter

  2. If a user specifies a model that does require a license and the user has provided a single "catch all" license then the tag of their image should not matter

  3. If a user specifies a model that does require a license and the user has not provided a license or has provided a license that matches a specific version other than the one they provided then the failure should clearly output during topology creation instead of the current behavior of hanging (presumably due to some wait or retry from kne <-> srl-controller) or bringing the pods up, marking them running, then realizing there is no license and continue into a crash loop

What work would you need on KNE to help achieve this in tandem with srl-controller changes? Do the above usecases seem like the right behavior to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the short term can you add the "ga" tag as recognized in the same way "latest" is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants