Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at refactoring test harness. It introduces unit tests that use controller-client fake client instead of doing integration tests with envtest right away.
The envtest-based test suite (that uses ginkgo) is moved to
./tests/integration
dir and is invoked right now automatically whenmake test
is called.Running only unit tests is possible with
make unit-test
.In future PRs I will carve out ginkgo from the integration test and use
go test
instead, based on the Cluster API examples - https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/controllers/machinedeployment/suite_test.go