-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CLI and JSON-styled startup configs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=========================================
+ Coverage 0 50.79% +50.79%
=========================================
Files 0 8 +8
Lines 0 758 +758
=========================================
+ Hits 0 385 +385
- Misses 0 346 +346
- Partials 0 27 +27
|
send it, baby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to provide startup configurations in both CLI and JSON formats.
Note, depends on openconfig/kne#343
Configs are still mounted to the srl pods, but instead of being copied to /opt/srlinux/config.json they are being loaded via CLI command.
In case of CLI-styled config:
In case of JSON:
with the following
commit now
.On the KNE side we provide the startup config file name, which is either config.cli or config.json. KNE checks if the provided file has
.json
extension, if yes - the file name isconfig.json
, else it isconfig.cli
.Additionally in this PR some chaotic changes are made to the way we update status and track if the update is needed. Very chaotic changes...