Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Deprecate and remove precomputes #60

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

hayesall
Copy link
Member

@hayesall hayesall commented Jun 9, 2022

There are a few references to precomputes still mentioned in the code.

e.g. One of the RDN methods is initializeRDNUsingPrecompute

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2022

This pull request fixes 1 alert when merging d3da4cd into 64f2789 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

@hayesall hayesall changed the title 🔥 Drop most Precompute code 🔥 Deprecate and remove precomputes Jun 9, 2022
@hayesall hayesall merged commit d601c1e into main Jun 9, 2022
@hayesall hayesall deleted the deprecate-precomputes branch June 9, 2022 15:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant