Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlayerDamageByPlayerEvent #1

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Add PlayerDamageByPlayerEvent #1

merged 3 commits into from
Jan 3, 2023

Conversation

srnyx
Copy link
Owner

@srnyx srnyx commented Jan 3, 2023

Description

Added the PlayerDamageByPlayerEvent event which will trigger when a player attacks another player (PVP). This event extends EntityDamageByEntityEvent

Motivation and Context

This is a simple feature that just makes it easier to listen to PVP.

How Has This Been Tested?

Tested by using another plugin and adding the PlayerDamageByPlayerEvent event handler. It works as intended.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@srnyx srnyx added the enhancement New feature or request label Jan 3, 2023
@srnyx srnyx merged commit 5bf1961 into main Jan 3, 2023
@srnyx srnyx deleted the playerdamagebyplayerevent branch January 3, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant