Skip to content

Commit

Permalink
streamingccl: don't require TLS certificates
Browse files Browse the repository at this point in the history
Users may want to use password auth to simplify their replication
setup. While we may recommend TLS certificate auth, I don't see a
strong reason to _require_ it.

Epic: none

Release note: None
  • Loading branch information
stevendanna committed May 9, 2023
1 parent 439c515 commit 7d0f283
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions pkg/ccl/streamingccl/streamingest/stream_ingestion_planning.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,6 @@ func ingestionPlanHook(
if err != nil {
return err
}
q := streamURL.Query()

// Operator should specify a postgres scheme address with cert authentication.
if hasPostgresAuthentication := (q.Get("sslmode") == "verify-full") &&
q.Has("sslrootcert") && q.Has("sslkey") && q.Has("sslcert"); (streamURL.Scheme == "postgres") &&
!hasPostgresAuthentication {
return errors.Errorf(
"stream replication address should have cert authentication if in postgres scheme: %s", streamAddress)
}

streamAddress = streamingccl.StreamAddress(streamURL.String())

// TODO(adityamaru): Add privileges checks. Probably the same as RESTORE.
Expand Down

0 comments on commit 7d0f283

Please sign in to comment.