Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Poe the Poet and Ruff for checks #201

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

srstevenson
Copy link
Owner

As we use Poetry for virtual environment management, we don't require most of Nox's functionality. Poe the Poet runs more quickly, and requires fewer lines of configuration. Ruff provides a single tool which can replace flake8, pylint, pyupgrade, and isort, whilst running more quickly.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.13% 🎉

Comparison is base (e0c4222) 98.28% compared to head (747c694) 99.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   98.28%   99.41%   +1.13%     
==========================================
  Files           3        3              
  Lines         175      172       -3     
==========================================
- Hits          172      171       -1     
+ Misses          3        1       -2     
Files Changed Coverage Δ
src/nb_clean/__init__.py 100.00% <100.00%> (ø)
src/nb_clean/cli.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As we use Poetry for virtual environment management, we don't require
most of Nox's functionality. Poe the Poet runs more quickly, and
requires fewer lines of configuration. Ruff provides a single tool
which can replace flake8, pylint, pyupgrade, and isort, whilst
running more quickly.
@srstevenson srstevenson marked this pull request as ready for review August 21, 2023 22:02
@srstevenson srstevenson merged commit 2e2c2e0 into main Aug 21, 2023
6 checks passed
@srstevenson srstevenson deleted the srs/poe-ruff branch August 21, 2023 22:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant