Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests not cleaning up properly #696

Closed
tlhackque opened this issue Aug 15, 2021 · 1 comment
Closed

Some tests not cleaning up properly #696

tlhackque opened this issue Aug 15, 2021 · 1 comment
Assignees
Labels

Comments

@tlhackque
Copy link
Contributor

As noted in #691:

Some tests (e.g. 17-test-spaces-in-sans-http01) assume that the last test will clean up the environment. This won't happen if skipped. The cleanup should be in teardown_file() functions instead.

I didn't have time to go through all the tests (I think there were over 150 files, but most of the changes were automated...). These cases can probably be identified and addressed incrementally.

@timkimber timkimber self-assigned this Aug 25, 2021
@timkimber timkimber added the bug label Aug 25, 2021
@timkimber
Copy link
Member

Thanks - I'll take a look and fix

timkimber added a commit to timkimber/getssl that referenced this issue Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants