branch should show whether the thread has branched #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me! does this fix #14? |
|
yes it does. |
mmckegg
approved these changes
May 20, 2017
|
👍 |
|
yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so if there was a concurrent comment on a thread (say, several people respond while offline) then that is recorded. This was the behavior in patchbay classic. patchwork and patchbay@7 both do not do anything with the branch except for put it in the message, so this shouldn't break anything, but updating them to use patchcore with this merged will have the correct behavior.
We'll need to have this behavior so we can have out of order repiles that work as you would expect, because you'll be able to trace the whole thread backwards from the reply you see, otherwise, you'll tend to get different views of the thread, which may disadvantage people who tend to use ssb while offline.