Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] GR6 Data at Rest - added additional policy check and resource based compliance status #139

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Jun 4, 2024

Overview/Summary

This pull request introduces additional resource-based logic while determining the compliance status.

This PR fixes/adds/changes/removes

  1. Added two more policy checks ("Storage accounts should restrict network access" and "Secure transfer to storage accounts should be enabled") in the required PBMM policy
  2. Added additional resource-based logic while determining the compliance status. This change not only checks 'PBMM policy applied', But also finds the number of non-compliant resource(s) for any required policies and determines the compliance status of the resource based on non-compliant resources found.

Breaking Changes

None. However, users' compliance status may change.

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 linked an issue Jun 4, 2024 that may be closed by this pull request
@dutt0 dutt0 merged commit d5a0869 into main Jun 5, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/gr6_additional_policy_check branch June 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR6: Add additional policy checks to existing control
3 participants