Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - MultiCloud Usage Profile integration to all Guardrails and Workbook #188

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Aug 27, 2024

Overview/Summary

This Pull Request updates the Azure guardrails solution accelerator to support multi-cloud usage profiles. It includes enhancements to the workbook, ensuring that the compliance status accurately reflects "Not Applicable" when a module run does not fall under a specific profile. Additionally, refactoring and code cleanup have been performed across the codebase to improve maintainability and functionality.

This PR fixes/adds/changes/removes

  1. Added multi-cloud usage profiles to the guardrails.
  2. Updated the workbook to display "Not Applicable" for non-profile module runs.
  3. Refactored and cleaned up code across the codebase.

Breaking Changes

  1. Refactored code may impact existing custom scripts or automation depending on the previous structure.
  2. Updated PowerShell module versions may require downstream dependencies to be updated as well.

Testing Evidence

Testing has been conducted to ensure the new multi-cloud profiles are correctly applied and that the workbook displays the appropriate compliance status. The following screenshots and logs demonstrate the successful application of these changes:
image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • [] Updated relevant and associated documentation.
  • Ensured PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@singhgss singhgss marked this pull request as ready for review August 28, 2024 21:03
@singhgss singhgss changed the title Gsingh/muc profile part2 MultiCloud Usage Profile integration to all Guardrails and Workbook Aug 28, 2024
@singhgss singhgss changed the title MultiCloud Usage Profile integration to all Guardrails and Workbook [Enhancement] - MultiCloud Usage Profile integration to all Guardrails and Workbook Aug 28, 2024
Copy link
Contributor

@dutt0 dutt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@singhgss singhgss merged commit d99cfc2 into main Sep 3, 2024
4 checks passed
@singhgss singhgss deleted the gsingh/muc-profile-part2 branch September 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Cloud Usage Profile Integration into Azure Compliance as Code
3 participants