-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] - MultiCloud Usage Profile integration to all Guardrails and Workbook #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhgss
changed the title
Gsingh/muc profile part2
MultiCloud Usage Profile integration to all Guardrails and Workbook
Aug 28, 2024
singhgss
changed the title
MultiCloud Usage Profile integration to all Guardrails and Workbook
[Enhancement] - MultiCloud Usage Profile integration to all Guardrails and Workbook
Aug 28, 2024
dutt0
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alalvi00
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This Pull Request updates the Azure guardrails solution accelerator to support multi-cloud usage profiles. It includes enhancements to the workbook, ensuring that the compliance status accurately reflects "Not Applicable" when a module run does not fall under a specific profile. Additionally, refactoring and code cleanup have been performed across the codebase to improve maintainability and functionality.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Testing has been conducted to ensure the new multi-cloud profiles are correctly applied and that the workbook displays the appropriate compliance status. The following screenshots and logs demonstrate the successful application of these changes:
As part of this Pull Request I have
main
branch./tools/Update-ModuleVersions.ps1
script)