Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relevant comments when no VNET is present #46

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add relevant comments when no VNET is present #46

merged 2 commits into from
Dec 13, 2023

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Dec 13, 2023 •
edited
Loading

Overview/Summary

When no VNET is present, network watcher module will show following as comment

Either due to no VNETs or all VNETs being excluded, there are no regions to check for Network Watcher configuration

This PR fixes/adds/changes/removes

  1. When no VNET present, network watcher module will show relevant comment instead of an empty message

Breaking Changes

N/A

Testing Evidence

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@singhgss singhgss linked an issue Dec 13, 2023 that may be closed by this pull request
Error Handling: GR9 errors in the workbook if no VNets are part of the tenant v1.1.8 #12
Closed
@singhgss singhgss merged commit 031c32b into main Dec 13, 2023
3 checks passed
@singhgss singhgss deleted the gsingh/show-comments-for-network-watcher-when-no-vnet branch December 13, 2023 15:09
dutt0 pushed a commit that referenced this pull request Feb 1, 2024
@singhgss
Add relevant comments when no VNET is present (#46)
258a8ad 
* Add relevant comments when no vnet is present

* update zipped module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalvi00 alalvi00 alalvi00 approved these changes

@dutt0 dutt0 dutt0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Handling: GR9 errors in the workbook if no VNets are part of the tenant v1.1.8
3 participants
@singhgss @alalvi00 @dutt0