Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to the installation instructions based on my experience… #165

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

kogut
Copy link
Collaborator

@kogut kogut commented Dec 30, 2019

… with Mint 19.

For me, libprce3 was needed for building cppcheck on Mint 19.

Also the installation requirements didn't automatically install as given (though maybe it's useful to preview what happens before actually installing).

@denewiler
Copy link
Collaborator

The Travis job for Python 3.4 failed. I addressed the underlying issue in #166 and #167. The PR for the fix was merged into master. Can you merge master into your branch for this PR? I can't figure out a way to do that without your help. After you merge master and push I can take care of re-running the Travis jobs if they don't automatically start again.

@kogut
Copy link
Collaborator Author

kogut commented Dec 31, 2019

I merged master into my fork.

@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          44       44           
  Lines        2177     2177           
=======================================
  Hits         2058     2058           
  Misses        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d7405...d463ec6. Read the comment docs.

@denewiler denewiler merged commit 56877f2 into sscpac:master Dec 31, 2019
axydes pushed a commit to axydes/statick that referenced this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants