Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store measured data from calibration in Calibrator.Config #165

Open
jamienoss opened this issue Sep 4, 2024 · 2 comments
Open

Store measured data from calibration in Calibrator.Config #165

jamienoss opened this issue Sep 4, 2024 · 2 comments
Assignees
@jamienoss
Labels
calibration enhancement New feature or request new feature refactor

Comments

@jamienoss
Copy link
Member

Punt from #157

See #157 (comment)

        measured_data: dict | None = Field(
            None,
            description="The data measured by a calibration procedure run. This can be specified instead of specifying "
            "some transformer config params, e.g., polynomial coefficients. This data will be fitted upon "
            "first use.",
        )
jamienoss added a commit that referenced this issue Sep 4, 2024
@jamienoss
Revert Calibrator.Config.measured_data - punt to #165
a830528 
Signed-off-by: James Noss <jnoss@jhu.edu>
@jamienoss jamienoss mentioned this issue Sep 4, 2024
Merged
@jamienoss jamienoss self-assigned this Sep 4, 2024
jamienoss added a commit that referenced this issue Sep 9, 2024
@jamienoss
Revert Calibrator.Config.measured_data - punt to #165
9a83a81 
Signed-off-by: James Noss <jnoss@jhu.edu>
jamienoss added a commit that referenced this issue Sep 9, 2024
@jamienoss
147 call transformers for temp (#157)
3e46745 
* 147-call-transformers-for-temp-calibration

Signed-off-by: James Noss <jnoss@jhu.edu>

* Revert Calibrator.Config.measured_data - punt to #165

Signed-off-by: James Noss <jnoss@jhu.edu>

---------

Signed-off-by: James Noss <jnoss@jhu.edu>
@jamienoss jamienoss mentioned this issue Sep 17, 2024
Closed
@imaitland imaitland changed the title Store measured data from calibration in Calibration.Config Store measured data from calibration in Calibrator.Config Oct 10, 2024
@imaitland
Copy link
Collaborator

Worked this into the calibration procedure pr with Jamie's feedback.

@jamienoss jamienoss mentioned this issue Oct 16, 2024
Open
@jamienoss
Copy link
Member Author

This is related to #179 as that calibration_file is CalibrationData.

This was referenced Nov 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamienoss jamienoss

Labels
calibration enhancement New feature or request new feature refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamienoss @imaitland