Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iainland/healthz html response #158

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

imaitland
Copy link
Collaborator

Screenshot 2024-08-30 at 12 06 20 PM

As part of the work to make the on-board 7" display show useful information about the evolver, we need an endpoint that responds with useful html.

This can be fleshed out as the requirements for what the on-board display should show emerge.

@imaitland imaitland requested a review from a team as a code owner August 30, 2024 16:08
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

jamienoss
jamienoss previously approved these changes Sep 3, 2024
Copy link
Member

@jamienoss jamienoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Not for this PR but I opened #163 as it would be cool to report the on/off status of the 12V system in the healthcheck.

Comment on lines 88 to 89
hostname = socket.gethostname()
ip_address = socket.gethostbyname(hostname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider #164

@imaitland
Copy link
Collaborator Author

Updated PR to route HTML api at /html route.

Screenshot 2024-09-10 at 12 06 59 PM

@imaitland imaitland requested a review from jamienoss September 10, 2024 16:11
Copy link
Member

@jamienoss jamienoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@imaitland imaitland merged commit 5d06993 into main Sep 10, 2024
8 checks passed
@imaitland imaitland deleted the iainland/healthz-html-response branch September 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants