-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iainland/healthz html response #158
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Not for this PR but I opened #163 as it would be cool to report the on/off status of the 12V system in the healthcheck.
evolver/app/main.py
Outdated
hostname = socket.gethostname() | ||
ip_address = socket.gethostbyname(hostname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider #164
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As part of the work to make the on-board 7" display show useful information about the evolver, we need an endpoint that responds with useful html.
This can be fleshed out as the requirements for what the on-board display should show emerge.