Iainland/refactor history endpoint - split GET and POST handlers #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
amitschang
reviewed
Nov 11, 2024
There was a problem hiding this comment.
If I recall, I think that fastapi didn't handle the list type (vials, properties) from query parameters (GET) and while it does look like the server will process the body of GET, POST is more fitting for this.
I'm not sure this would work due to the list types, but even then, perhaps we just get rid of the GET in favor of only POST?
|
ok got it, yeah we should have only one. I'm ok with POST only. Will make that change. using GET and a body was causing the TS client to complain. whatwg/fetch#551 |
imaitland
force-pushed
the
iainland/refactor-history-endpoint
branch
from
3ef800f to
28f7f93
Compare
amitschang
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP standards demand GET requests do not include a body, all GET params must be passed as query elements.