-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename adapter -> controller #31
Conversation
9ef2cb9
to
d21b429
Compare
d21b429
to
e79966d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments inline
@@ -10,7 +10,7 @@ | |||
DEFAULT_HISTORY = HistoryServer | |||
|
|||
|
|||
class AdapterDescriptor(pydantic.BaseModel): | |||
class ControllerDescriptor(pydantic.BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was already in place and was confusing before, but since this is more generic than controller (it is used for controller and hardware), maybe should be DriverDescriptor
, or PluginDescriptor
or something. If we don't change here I can make an issue to track that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitschang I think this would be better if just nuked and replaced with evolver.base.BaseConfig
, sound good to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't change in this PR though, there's a much-needed refactor to incorporate the construction pattern from #37 and this can get addressed then.
""" Hook for customization post-control execution, see self.run(). """ | ||
pass | ||
|
||
def run(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a test or two for this, especially the return mutation to be sure we capture the desired mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't really sure what you were expecting here but I at least added some very rudimentary tests for you.
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
Signed-off-by: James Noss <jnoss@jhu.edu>
384332b
to
e756926
Compare
Signed-off-by: James Noss <jnoss@jhu.edu>
e756926
to
a9395d9
Compare
Signed-off-by: James Noss <jnoss@jhu.edu>
Resolves #25
I had thought about adding context manager funcs, but it didn't quite make sense for this. The only example I could think of is when running multiple controls, i.e., when doing one thing, you then want to do another, but 🤷 .
However, the above examples require concurrency...