bootstrapping package from template #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitschang
force-pushed
the
bootstrap
branch
from
e067d80 to
9a5aa32
Compare
jamienoss
reviewed
Feb 20, 2024
| @@ -80,7 +80,7 @@ exclude = [ | |||
| "_version.py" | |||
| ] | |||
|
|
|||
| ignore = [ | |||
| lint.ignore = [ | |||
There was a problem hiding this comment.
Looks like a needed back-port.
There was a problem hiding this comment.
yes, I will do it shortly 😄
jamienoss
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Looks good to me other than the one missing change in docs/source/conf.py
https://github.com/ssec-jhu/evolver-ng/blob/main/docs/source/conf.py#L51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just bootstrapping from the template, including all the version upgrades that dependabot wants to make packaged into one for simplicity. Also not bothering with codecov at the moment, but can sort that out later.