Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable integration test Test_Sftp_Multiple_Async_Upload_And_Download_10Files_5MB_Each #1253

Open
WojciechNagorski opened this issue Nov 29, 2023 · 6 comments
Open

Unstable integration test Test_Sftp_Multiple_Async_Upload_And_Download_10Files_5MB_Each #1253

WojciechNagorski opened this issue Nov 29, 2023 · 6 comments
Assignees
@Rob-Hague

Comments

@WojciechNagorski
Copy link
Collaborator 

Failed Test_Sftp_Multiple_Async_Upload_And_Download_10Files_5MB_Each [9 s]
  Error Message:
   Assert.IsTrue failed. Uploaded and downloaded bytes does not match
  Stack Trace:
     at Renci.SshNet.IntegrationTests.OldIntegrationTests.SftpClientTest.Test_Sftp_Multiple_Async_Upload_And_Download_10Files_5MB_Each() in /home/appveyor/projects/ssh-net/test/Renci.SshNet.IntegrationTests/OldIntegrationTests/SftpClientTest.Upload.cs:line 233
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
  Standard Output Messages:
 SSH Server host name: 127.0.0.1
 SSH Server port: 32769
 5iovfbli.ykm
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 1b829b119bfeb98e8446755911d7d680
 DownloadedHash: 1b829b119bfeb98e8446755911d7d680
 glzjnmjw.iiq
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 8e0c19f0a0a8d291e9ced2a5e608e322
 DownloadedHash: 8e0c19f0a0a8d291e9ced2a5e608e322
 quhkvyug.zy3
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 4c70cfc9e8f4aa12f6a793042fdba776
 DownloadedHash: 4c70cfc9e8f4aa12f6a793042fdba776
 ypghiybv.4cm
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: d3c949929[381](https://ci.appveyor.com/project/drieseng/ssh-net/build/job/laf9893flglsi6rg#L381)1b03588f857761f407f5
 DownloadedHash: d3c9499293811b03588f857761f407f5
 x4db0pr0.dhb
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: e658a12e0ff01f0d035b4a994c82c491
 DownloadedHash: e658a12e0ff01f0d035b4a994c82c491
 fmwna44p.dxc
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 9e1344cc1f556b9eb91beda2e08d5f06
 DownloadedHash: 9e1344cc1f556b9eb91beda2e08d5f06
 iq13zo04.2xz
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 45cd97ebe2c943a38e9a4254ab984e44
 DownloadedHash: 45cd97ebe2c943a38e9a4254ab984e44
 e4rrcgsd.303
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: f6f91ee74b9f359a698a8c7c1cbedce5
 DownloadedHash: f6f91ee74b9f359a698a8c7c1cbedce5
 kxnlrzbo.5cm
 UploadedBytes: 5242880
 DownloadedBytes: 5242880
 UploadedHash: 085db7b088cdc29444db63b26157317f
 DownloadedHash: 085db7b088cdc29444db63b26157317f
 2rwf4c0a.mq4
 UploadedBytes: 5242880
 DownloadedBytes:  5240800  <---- here is a problem
 UploadedHash: 196682a78dea5da9c6d6d79c0427ce20
 DownloadedHash: 196682a78dea5da9c6d6d79c0427ce20
WojciechNagorski added a commit to WojciechNagorski/SSH.NET that referenced this issue Nov 29, 2023
@WojciechNagorski
Issue sshnet#1253
25e0aac
@Rob-Hague
Copy link
Collaborator

Fixed by #1184

WojciechNagorski added a commit that referenced this issue Nov 30, 2023
@WojciechNagorski @Rob-Hague @scott-xu
Test integration tests (#1250)
d3641a0 
* Test integration tests

* Update appveyor.yml

* Update appveyor.yml

* Update Dockerfile

* Update appveyor.yml

* test?

* Test

* Enable docker

* Update appveyor.yml

* Update appveyor.yml

* Fix & Show additional information

* Try to fix connection problems

* Fix build

* remove artifacts

* Enable logging

* Log Information only

* Update appveyor.yml

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

* Update appveyor.yml

* Update appveyor.yml

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

* Update appveyor.yml

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* sleep after restarting

* Update RemoteSshd.cs

* Fix tests

* Dispose ports

* Small improvements

* Fix build

* Small fixes

* Revert not related changes

* Test linux and windows

* fix

* test_script

* Use real commands

* Fixes

* fix?

* Add Appveyor TestLogger

* Fix linux tests

* Fix tests

* Try to fix tests

* Revert

* Give time before

* fix

* revert

* Give some time to process all messages after connect

* ForwardedPortDynamicTest_Stop_PortStarted_ChannelNotBound

* fix netsh

* trace

* Update appveyor.yml

* Update appveyor.yml

* etl2pcapng

* Update appveyor.yml

???

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* come on !!

* Update appveyor.yml

* Fixes tests for linux

* Reverts

* Fix build

* Update TestMethodForPlatformAttribute.cs

* Update TestMethodForPlatformAttribute.cs

* Update appveyor.yml

* Issue #1253

* Install .NET SDK

* next try

* fix?

* try

* Finishing

* Fixes

* apt-get install dotnet-sdk-7.0

* Finish?

* Add environment APPVEYOR_BAKE_IMAGE

* Update test/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_TimeoutConnectingToServer.cs

Co-authored-by: Rob Hague <rob.hague00@gmail.com>

* Fix review

* Fix

* Update appveyor.yml

* Update appveyor.yml

* Delete .runsettings

---------

Co-authored-by: Rob Hague <rob.hague00@gmail.com>
Co-authored-by: Robert Hague <rh@johnstreetcapital.com>
Co-authored-by: Scott Xu <scott-xu@msn.com>
@scott-xu
Copy link
Collaborator

scott-xu commented Dec 9, 2023

Can this issue be closed? @WojciechNagorski

@WojciechNagorski
Copy link
Collaborator Author

I think it can. if something fail we will open it.

@Rob-Hague
Copy link
Collaborator

It failed in https://ci.appveyor.com/project/drieseng/ssh-net/builds/48717790/job/ablpqnf51m4drswd/tests 🙁

@Rob-Hague
Copy link
Collaborator

Maybe it's related to #957

@Rob-Hague Rob-Hague self-assigned this Dec 9, 2023
@Rob-Hague Rob-Hague mentioned this issue Sep 14, 2024
Open
@Rob-Hague
Copy link
Collaborator

sshd says

debug sshd.pam[24]: debug2: channel 0: window 524288 sent adjust 32768
debug sshd.pam[24]: debug2: channel 0: window 557056 sent adjust 16384
err internal-sftp[25]: error: bad message from 172.17.0.1 local user sshnet   <--------
debug sshd.pam[24]: debug2: channel 0: read 0 from efd 10
debug sshd.pam[24]: debug2: channel 0: closing read-efd 10
debug sshd.pam[24]: debug1: Received SIGCHLD.

SSH.NET says

Channel#1 received request exit-status 11

It comes from https://github.com/openssh/openssh-portable/blob/49f325fd47af4e53fcd7aafdbcc280e53f5aa5ce/sftp-server.c#L1818-L1822

SFTP_MAX_MSG_LENGTH is 256 * 1024. As far as I can tell we comply with the server channel window and also do not exceed 32 * 1024 for an SFTP packet. It looks like sshd pipes the channel data to stdin of the sftp process - I don't see it combining packets or anything like that. Don't know how that SFTP_MAX_MSG_LENGTH check is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rob-Hague Rob-Hague

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scott-xu @Rob-Hague @WojciechNagorski