Update version in client string for new releases #1292
Comments
|
After #1256, it might be possible to achieve this by using the MSBuild WriteLinesToFile task to write out the Version property as a constant in the source. It might already be possible with WriteCodeFragment to get the AssemblyVersion attribute |
scott-xu
added a commit
to scott-xu/SSH.NET
that referenced
this issue
Jan 29, 2024
scott-xu
added a commit
to scott-xu/SSH.NET
that referenced
this issue
Jul 26, 2024
sendevman
pushed a commit
to sendevman/SSH.NET
that referenced
this issue
Sep 1, 2024
* GeneratePackageOnBuild IncludeSymbols * Add packages to artifacts * Update src/Renci.SshNet/Renci.SshNet.csproj Co-authored-by: Rob Hague <rob.hague00@gmail.com> * Update Renci.SshNet.csproj Co-authored-by: Rob Hague <rob.hague00@gmail.com> * Delete build/nuget/SSH.NET.nuspec * Delete SSH.NET.nuspec from .sln file * Update Renci.SshNet.csproj * Update build.proj * init nbgv * Include version.json in "Solution Items" * Update Directory.Build.props * define publicReleaseRefSpec * update version.json * update version.json * set cloud build number * fix sshnet/SSH.NET#1292 * remove unexpected code format * Delete version from csproj * move nbgv from Directory.Build.props to Renci.SshNet.csproj as only this particular project needs versioning. include package version in ThisAssembly and use nuget package version for the SSH client version. Since we define the precision of nuget package to "build", it has 3 digits. Nuget package version is unique which should be suffient. * Use package from CI feed * Bump version to 2024.0.1; Update version precision * Some tweaks: - Remove the "release" section. I don't think we will use that for now - Remove the "cloudBuild" section. Changing the CI build number doesn't seem that useful - In the "nugetPackageVersion" section: - Remove "precision". It defaults to build - Add "semVer"=2. This makes the package version e.g. 2024.1.1-prerelease.1 instead of 2024.1.1-prerelease-0001 - In "assemblyVersion" change "precision" to revision. Doesn't seem to change anything, I was just copying nbgv's setup: https://github.com/dotnet/Nerdbank.GitVersioning/blob/main/version.json - Make sure there are no '-' in the softwareversion string (change the test to a regex) * Revert unnecessary test changes; remove unnecessary tests --------- Co-authored-by: Rob Hague <rob.hague00@gmail.com> Co-authored-by: Robert Hague <rh@johnstreetcapital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The client string set here is static and hasn't been updated in eight years.
Updating this to reflect the released version would assist SSH service operators in auditing their clients' capabilities before updating supported ciphers and key-exchange algorithms.
The text was updated successfully, but these errors were encountered: