Send the client key exchange init in Connect #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
requested review from
drieseng and
WojciechNagorski
as code owners
|
I will check this next week. |
|
Can we prepare tests to cover two cases? When does server initialization occur and when does it not? |
|
Added a unit test for when the server does not send kexinit edit:
The RFC says "Key exchange (kex) begins by each side sending name-lists of supported algorithms." I.e. there is no indication that the client or server should wait for the other. SSH.NET currently waits for the server to send its supported algorithms. This works OK against most server implementations, but if the server is waiting for SSH.NET, then we have a problem. |
This was referenced Dec 21, 2023
Closed
Closed
Renci.SshNet.Common.SshConnectionException: An established connection was aborted by the server
#578
Closed
This was referenced Dec 21, 2023
Closed
Closed
Closed
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion in #972, I have been running this in production against several different servers for a week or so.
An example key exchange with this change:
And an example when the server init comes in first:
cc @geoffstewart