Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable nullable on BaseClient and SftpClient #1339

Merged
merged 2 commits into from
Apr 17, 2024
Merged

enable nullable on BaseClient and SftpClient #1339

merged 2 commits into from
Apr 17, 2024

Conversation

mus65
Copy link
Contributor

@mus65 mus65 commented Feb 24, 2024

This is just a start to get some feedback, I could do more of the public APIs.

Rob-Hague
Rob-Hague approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

For future reference, it is easier if you can avoid force-pushing once a review has started (merge develop into the PR branch to fix conflicts if possible). Then the new changes can more easily be seen

@Rob-Hague Rob-Hague merged commit 4cab7e5 into sshnet:develop Apr 17, 2024
1 check passed
@mus65 mus65 mentioned this pull request May 5, 2024
Merged
@mus65 mus65 deleted the sftpclientnullable branch September 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mus65 @Rob-Hague