Fix CancelAsync Cause Deadlock #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
reviewed
Mar 11, 2024
test/Renci.SshNet.IntegrationTests/OldIntegrationTests/SshCommandTest.cs
Outdated
Show resolved
Hide resolved
test/Renci.SshNet.IntegrationTests/OldIntegrationTests/SshCommandTest.cs
Outdated
Show resolved
Hide resolved
| @@ -356,13 +357,12 @@ public string EndExecute(IAsyncResult asyncResult) | |||
| /// <summary> | |||
| /// Cancels command execution in asynchronous scenarios. | |||
| /// </summary> | |||
| public void CancelAsync() | |||
| /// <param name="forceKill">if true send SIGKILL instead of SIGTERM.</param> | |||
| public void CancelAsync(bool forceKill = false) | |||
There was a problem hiding this comment.
Perhaps we drop the Async suffix here (and obsolete CancelAsync) as it is not an async method. @WojciechNagorski?
Rob-Hague
reviewed
Mar 23, 2024
Rob-Hague
reviewed
Mar 23, 2024
Rob-Hague
approved these changes
Mar 24, 2024
WojciechNagorski
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Unfortunately, I don't have much time for this project at the moment. Only PRs that have @Rob-Hague's approval are verified and merged by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CancelAsync causing deadlocking:
it now signal WaitHandle of Cancelled event after sending SIGTERM/SIGKILL signal to try to abort the request.
close #1147 and close #1023