-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More AsyncSocketListener patchwork #1408
Conversation
This is Whack-a-mole part 2 in diagnosing or preventing the test host from crashing in CI.
{ | ||
bytesRead = 0; | ||
} | ||
bytesRead = handler.EndReceive(ar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite being documented as throwing, EndReceive(IAsyncResult, out SocketError)
actually suppresses exceptions and translates them into the out SocketError
parameter, at which point we would continue on and call ConnectionDisconnected(true)
, giving another way to crash.
Here is the/a culprit https://ci.appveyor.com/project/drieseng/ssh-net/builds/49841011/job/44weuub8v0om0tyr/tests Renci.SshNet.Tests.Classes.Channels.ChannelDirectTcpipTest_Dispose_SessionIsConnectedAndChannelIsOpen.BindShouldHaveFinishedWithoutException
|
@WojciechNagorski please sign off on this one when you get a chance. No rush |
Thanks |
This is Whack-a-mole part 2 in diagnosing or preventing the test host from crashing in CI.