Bugfix, left-factoring of mapping rules. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to abbreviate a collection of rules where the same OSC message is
mapped to different MIDI messages. E.g.,
/multi/{i} ff, touch,x,y : controlchange( channel, touch, x*127);
/multi/{i} ff, touch,x,y : controlchange( channel, touch+10, y*127);
may now be written as:
/multi/{i} ff, touch,x,y : controlchange( channel, touch, x*127);
: controlchange( channel, touch+10, y*127);
Note that the latter simply gets expanded to the former. There's no change in
semantics (except that an OSC message path can't start with a colon any
longer, but that's rather unlikely anyway).
|
looks good. I'd thought about implementing left factoring but hadn't really come up with a good way to do it. Thanks! |
ssj71
added a commit
that referenced
this pull request
Jun 30, 2015
Bugfix, left-factoring of mapping rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 308b45b fixes a rather awful bug which probably got unveiled by commit 0d895bc, causing
osc_mapfields to remain uninitialized. I'd say that this is critical enough to warrant a new point release.As a bonus, commit ee3ec6b lets you leave out the left-hand side osc message of a rule if it's the same as for the previous rule. This saves a lot of typing in cases where a single osc message maps to an entire collection of different midi messages. E.g.,
may now be written as:
(The whitespace at the beginning of the second line is purely cosmetic, of course.)
I'd say that this is rather convenient. The only downside is that an osc message path may not start with a colon any more, but I consider this rather unlikely anyway. What do you think?