(#247) slow 3G 환경에서도 #247이 여전히 재현되는 버그 수정 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix: #247 resetContent before async createPost not to save draft on submit
koyrkr
approved these changes
Apr 2, 2023
Comment on lines
+69
to
+72
| // FIXME: feed는 캐싱하면 의도치 않게 stale한 응답을 보여줄 수 있음 | ||
| refetchFriendPostList({ refetchPage: () => true }); | ||
|
|
||
| if (location.pathname === '/questions') history.push('/home'); |
There was a problem hiding this comment.
어차피 home으로 redirect 시켜주고 refetch를 할 거면
useInfiniteFriendPostList 안에서
refetchOnMount: true
option을 주는 건 어떨까요?
feed는 말씀대루 특성상 캐싱이 되는 것을 최소화하는게 맞는 것 같고,
고러면 refetchFriendPostList도 /home이 아닌 곳에서 굳이 할 필요 없지 않나 싶어서요!
There was a problem hiding this comment.
네! 이건 오늘 얘기한 scroll 유지 기능 스펙아웃 검토하면서 같이 검토해보기로 해요~~
캐시할 필요가 없어지만 지나님 말씀대로 refetchOnMount되도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #247
Self Check List
Types of changes
What does this PR do?
resetContent를createPost보다 먼저 실행해서 게시할 때도 draft로 저장되지 않도록 수정createPost가 완료된 이후 되도록 해서, 이전 캐싱된 feed를 보여주지 않도록 수정Preview Image
2023-04-02.8.34.35.mov
Further comments