Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunConfiguration settings from application settings #16

Open
ssnenov opened this issue Oct 10, 2016 · 0 comments
Open

RunConfiguration settings from application settings #16

ssnenov opened this issue Oct 10, 2016 · 0 comments
Assignees
Milestone

Comments

@ssnenov
Copy link
Owner

ssnenov commented Oct 10, 2016

Requirements

RunConfiguration should read application settings using ConfigurationManager. All settings read from AppSettings element should be stored in a collection (e.g. Dictionary<string, string> or NameValueCollection as it's in ConfigurationManager) in RunConfiguration class. Existing strongly typed settings also should read from AppSettings section if they aren't explicitly set.

In order to separate settings prepared for Html2Amp, the keys from AppSettings elements should be filtered. For example: all keys starting with "Html2Amp:".
The key name will be next after the prefix. For example: "Html2Amp:[key name]"
Example:

<appSettings>
    <add key="Html2Amp:RelativeUrlsHost" value="http://integration.mywebsite.com" />
</appSettings>

Why

This will enable Html2Amp to be easily extendable and continues integration friendly.

@ssnenov ssnenov added this to the 1.1.0 milestone Nov 5, 2016
@ssnenov ssnenov self-assigned this Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant