Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thai language support #629

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Add Thai language support #629

merged 15 commits into from
Sep 17, 2024

Conversation

mmmmmob
Copy link
Contributor

@mmmmmob mmmmmob commented Sep 13, 2024

Resolves #628

Adding Thai.yml and th-utf8.csv dictionary

@sspanak sspanak added the languages Dictionary or language related issues label Sep 13, 2024
@sspanak
Copy link
Owner

sspanak commented Sep 13, 2024

Please, see my comments in #628

@mmmmmob
Copy link
Contributor Author

mmmmmob commented Sep 15, 2024

finished adding new dictionary with 18k words (tested and passed) @sspanak

@sspanak
Copy link
Owner

sspanak commented Sep 15, 2024

Excellent! Could you please also add links to the websites where you got the word lists from?

@mmmmmob
Copy link
Contributor Author

mmmmmob commented Sep 15, 2024

Word lists based from this repository which you mentioned in the issue. I think this one is okay because the owner extracted all the words from the Royal Institute Dictionary

There are some duplicate words in the original .txt file which I've cleared all of them and tested on Android Studio already.

@sspanak
Copy link
Owner

sspanak commented Sep 15, 2024

Perfect, thank you! I'll try to do my part as soon as possible, then merge it.

@sspanak
Copy link
Owner

sspanak commented Sep 16, 2024

Remaining tasks to do:

  • Sort the dictionary
  • Make sure the double character vowels work properly.

@sspanak sspanak self-requested a review September 16, 2024 15:29
@sspanak sspanak merged commit d5fc1fe into sspanak:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages Dictionary or language related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thai language support
2 participants