Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider to take table-name when querying secret. #11

Merged
merged 5 commits into from
Oct 13, 2018

Conversation

lomkju
Copy link
Contributor

@lomkju lomkju commented Oct 5, 2018

With one provider you can query multiple tables.

@tmichel
Copy link

tmichel commented Oct 5, 2018

I'm not sure that this is needed when you can have multiple instances of a provider with different configuration: https://www.terraform.io/docs/configuration/providers.html#multiple-provider-instances

I'd much rather keep the provider simple than to have functionality that duplicates what terraform offers out of the box.

Maybe a note in the README to point folks in the right direction would help since having multiple credstash tables is pretty common I guess. Let me know what you think.

@lomkju
Copy link
Contributor Author

lomkju commented Oct 8, 2018

Yes we can do that. We wanted this because we wanted to pass dynamic strings as the table-name and provider didn't allow locals to be passed. Only variables are allowed in the provider block.

@tmichel
Copy link

tmichel commented Oct 10, 2018

Thanks for the fixed build!

Can you please revert the Makefile and .gitignore files to their original state? Also if you could add a note to the README about how to override the table that would be superb.

After these we can merge this pull request.

@tmichel
Copy link

tmichel commented Oct 13, 2018

Thanks! I'll merge the PR and release a new version soon.

@tmichel tmichel merged commit 8b19e76 into sspinc:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants