This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
feat: disable telemetry with env var from v2 #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can we test this? Also, lets open an issue for this. |
sebws
force-pushed
the
feat/disable-telemetry-env-var
branch
from
a4a3408
to
61960d8
Compare
|
by test, do you mean write tests or just make sure it builds etc.? I've updated to include DO_NOT_TRACK and explicitly check the variables == 1. I've taken the language from the SST v2 docs for the description |
sebws
force-pushed
the
feat/disable-telemetry-env-var
branch
from
61960d8
to
986f4d2
Compare
|
Yeah can we also open an issue for this? |
|
Oh I see it. |
sebws
force-pushed
the
feat/disable-telemetry-env-var
branch
from
986f4d2
to
8df8197
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore functionality from v2. I've not actually built this yet and just made the edits on Github, sorry.
I think this should be added to the documentation, but not sure if it should be added to the CLI description of telemetry?