This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
fix: container environment variables #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellooh
changed the title
|
Thanks |
|
What's holding this pr back? Would love to get that fix. |
sellooh
force-pushed
the
fix/container-environment-variables
branch
from
5beaa68 to
1b08f1e
Compare
|
Had conflicts with my PR and just fixed them - would also like to get this fixed, I'm using a patched version of the component for now but would love to just use SST's |
sellooh
force-pushed
the
fix/container-environment-variables
branch
2 times, most recently
from
ac8c50d to
3d67f7f
Compare
|
Releasing v3.2.30 with this fix - sorry about the delay |
|
thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container variables are being ignored and top level environment can't be set when using
containersSince this condition doesn't allow to specify top level environment variables, there is no workaround atm:
ion/platform/src/components/aws/service.ts
Line 232 in 64a591a
This PR adds container env variables to the task definition
closes sst/sst#4012