Normalize $CARGO_HOME in license file path #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the remaining clippy warning I am not sure whether |
sstadick
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
@Skgland - thanks for making this! I got part way towards this a while ago and got distracted.
This LGTM. I made one suggestion. I'd also say that we might as well disable the Eq lint if you don't mind doing that. I need to add a rust-toolchain.toml for this to avoid regressions like that.
Once those two things are addressed I'll merge and make a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at resolving issue #8