-
Notifications
You must be signed in to change notification settings - Fork 518
Preserve empty output lines in $lines #93
base: master
Are you sure you want to change the base?
Conversation
It's no longer being modified in the parent shell
Merging this would have the same IFS issue discussed in #90, but I'd hate for you to hold off on a merge for only that reason. If it looks ok otherwise, I could always insert an |
Is this waiting on something? Is there anything I can do to help this get merged? (Edit: Also, this probably deserves a mention in the README — this completely and totally breaks |
Yes and yes. See discussion in #150. |
I believe this has already been resolved with #90 and can be closed? |
I'm not familiar with issue #90. I think the easiest way to see if that fixes the problem described here is to run this test with #90 applied: https://github.com/rfletcher/bats/blob/1523459bc7e7d934ea5e90d2dfbd8d7fac7ac1cb/test/bats.bats#L266-L273 If it passes, then great! If the |
We are hitting the problem on bats master (in combination with bats-assert) today. This issue still exists |
Empty lines in
$output
are lost when the$lines
array is set. That throws off the expected array index of any lines that follow. This patch preserves those empty lines.Note that the loop was used to support Bash < 4. Otherwise I would have used the new
readarray
builtin.