Partial Signature Verification Aggregation #46
Merged
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
requested changes
Mar 19, 2024
sips/reduce_signatures_no_fork.md
Outdated
| A partial signature message implies one RSA verification (in the message validation layer) and two BLS verifications (for `SignedPartialSignatureMessage` and `PartialSignatureMessage`). Notice that two signatures are used to verify that the sender is correct and one is used to verify if the (same) sender correctly signed the beacon partial signature. Therefore, we can, simply, ignore the first BLS signature since the RSA signature is already being checked. | ||
|
|
||
| > [!NOTE] | ||
| > Since we want a no-fork change, one must still BLS-sign twice to be compatible with the previous version. |
There was a problem hiding this comment.
There is still a rogue key attack vector here ;-\
There was a problem hiding this comment.
How is that? Can you give an example?
There was a problem hiding this comment.
Can't an attacker put a bad sig on the first BLS check simply?
There was a problem hiding this comment.
Yes, it can. But let's say one malicious operator creates an invalid signature on the SignedPartialSignatureMessage. What is the attack outcome in generating an inconsistent state?
4 tasks
MatheusFranco99
changed the title
liorrutenberg
approved these changes
Mar 27, 2024
GalRogozinski
approved these changes
Mar 27, 2024
moshe-blox
approved these changes
Mar 27, 2024
|
Any projected gains from this? in terms of speed/ CPU/ etc? |
|
@alonmuroch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SIP attempts to reduce the current cost of signature verification. Specifically, it boosts the partial signature steps, in which a quorum is needed to trigger some action. To accomplish that, it proposes performing a single BLS verification on the reconstructed signatures only when a quorum is reached.
The SIP is based on discussion #38.