-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deadlock when signing with the same validator in parallel #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0sher
requested review from
alonmuroch,
olegshmuelov,
moshe-blox and
liorrutenberg
and removed request for
alonmuroch
August 28, 2024 17:53
y0sher
changed the title
test: sign with the same validator in parallel on the same time.
fix: sign with the same validator in parallel on the same time.
Aug 28, 2024
MatusKysel
reviewed
Oct 23, 2024
MatusKysel
approved these changes
Oct 23, 2024
moshe-blox
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
y0sher
requested review from
olegshmuelov
and removed request for
olegshmuelov and
alonmuroch
October 27, 2024 14:52
olegshmuelov
approved these changes
Oct 27, 2024
moshe-blox
changed the title
fix: sign with the same validator in parallel on the same time.
fix: deadlock when signing with the same validator in parallel
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Together with @moshe-blox and with some input from @vaclav-ssvlabs and @zktaiga , we realized the change we are doing to
alan
might try signing with the same validator (for different slots) at the same time in parallel.Regression test added.
The bug