Spec - Drop redundant validation for decided messages (#476)

* Remove redundant validation * Align error string
ssvlabs · Aug 20, 2024 · b0f2b4d · b0f2b4d
1 parent 5daa242
commit b0f2b4d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/qbft/decided.go b/qbft/decided.go
@@ -75,18 +75,10 @@ func ValidateDecided(
 		return errors.New("not a decided msg")
 	}
 
-	if err := msg.Validate(); err != nil {
-		return errors.Wrap(err, "invalid decided msg")
-	}
-
 	if err := baseCommitValidationVerifySignature(msg, msg.QBFTMessage.Height, share.Committee); err != nil {
 		return errors.Wrap(err, "invalid decided msg")
 	}
 
-	if err := msg.Validate(); err != nil {
-		return errors.Wrap(err, "invalid decided")
-	}
-
 	r, err := HashDataRoot(msg.SignedMessage.FullData)
 	if err != nil {
 		return errors.Wrap(err, "could not hash input data")

diff --git a/qbft/spectest/generate/tests.json b/qbft/spectest/generate/tests.json
diff --git a/qbft/spectest/tests/controller/decided/duplicate_signers.go b/qbft/spectest/tests/controller/decided/duplicate_signers.go
@@ -25,6 +25,6 @@ func DuplicateSigners() tests.SpecTest {
 				},
 			},
 		},
-		ExpectedError: "invalid decided msg: invalid decided msg: invalid SignedSSVMessage: non unique signer",
+		ExpectedError: "invalid decided msg: invalid decided msg: signed commit invalid: invalid SignedSSVMessage: non unique signer",
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,6 @@ func DuplicateSigners() tests.SpecTest { @@
     				},
     			},
     		},
-    		ExpectedError: "invalid decided msg: invalid decided msg: invalid SignedSSVMessage: non unique signer",
+    		ExpectedError: "invalid decided msg: invalid decided msg: signed commit invalid: invalid SignedSSVMessage: non unique signer",
     	}
     }