Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voluntary Exit - Fix Beacon Node #319

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Voluntary Exit - Fix Beacon Node #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ssv/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ type ValidatorRegistrationCalls interface {
// VoluntaryExitCalls interface has all validator voluntary exit duty specific calls
type VoluntaryExitCalls interface {
// SubmitVoluntaryExit submits a validator voluntary exit
SubmitVoluntaryExit(voluntaryExit *phase0.SignedVoluntaryExit, sig phase0.BLSSignature) error
SubmitVoluntaryExit(voluntaryExit *phase0.SignedVoluntaryExit) error
}

type DomainCalls interface {
Expand Down
2 changes: 1 addition & 1 deletion ssv/voluntary_exit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (r *VoluntaryExitRunner) ProcessPreConsensus(signedMsg *types.SignedPartial
Signature: specSig,
}

if err := r.beacon.SubmitVoluntaryExit(signedVoluntaryExit, specSig); err != nil {
if err := r.beacon.SubmitVoluntaryExit(signedVoluntaryExit); err != nil {
return errors.Wrap(err, "could not submit voluntary exit")
}

Expand Down
2 changes: 1 addition & 1 deletion types/beacon_types_encoding.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/spectest/generate/tests.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion types/testingutils/beacon_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ func (bn *TestingBeaconNode) SubmitValidatorRegistration(pubkey []byte, feeRecip
}

// SubmitVoluntaryExit submit the VoluntaryExit object to the node
func (bn *TestingBeaconNode) SubmitVoluntaryExit(voluntaryExit *phase0.SignedVoluntaryExit, sig phase0.BLSSignature) error {
func (bn *TestingBeaconNode) SubmitVoluntaryExit(voluntaryExit *phase0.SignedVoluntaryExit) error {
r, _ := voluntaryExit.HashTreeRoot()
bn.BroadcastedRoots = append(bn.BroadcastedRoots, r)
return nil
Expand Down