Revert breaking encoding changes #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastsszwas upgraded in #324 and it changed the roots forConsensusData,SignedMessageandSSVMessage, which would be a fork.This
fastsszupgrade included a crucial hashing fix, replacingPutByteswithAppendin order to prevent double-merkleization inHashTreeRootmethods, thereby changing roots for[]bytefields exceeding 32 bytes.It's noted that Beacon spec tests appear unaffected by this change, as they don't contain fields exceeding the threshold for the double-merkleization bug. However, we don't know that Beacon messages are absolutely not impacted.
Therefore, we propose inspecting the changes in
_encoding.gofiles between the currently and previously imported versions of go-eth2-client, to ensure that any change fromPutBytestoAppendis encoding a field which can not exceed 32 bytes in size.Two more changes were done to preserve backwards-compatibility:
types.Contributionwas copied over fromv0.3.4spec.DataVersionis now being decremented in encodings and incremented in decodings, because all of the values were incremented by 1 in go-eth2-client.